Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Symfony 6] Use storage factory id option on test app #401

Merged
merged 1 commit into from
Apr 15, 2022
Merged

[Symfony 6] Use storage factory id option on test app #401

merged 1 commit into from
Apr 15, 2022

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Mar 30, 2022

Q A
Bug fix? yes (Symfony 6)
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@loic425 loic425 requested a review from a team as a code owner March 30, 2022 12:58
@loic425 loic425 mentioned this pull request Mar 30, 2022
Closed
16 tasks
@loic425 loic425 changed the title Use storage factory id option on test app [Symfony 6] Use storage factory id option on test app Apr 7, 2022
@loic425 loic425 changed the base branch from 1.8 to 1.9 April 7, 2022 13:58
@loic425 loic425 changed the base branch from 1.9 to 1.10 April 12, 2022 08:14
@lchrusciel lchrusciel added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Apr 15, 2022
@lchrusciel lchrusciel merged commit 4538969 into Sylius:1.10 Apr 15, 2022
@loic425 loic425 deleted the storage-factory-id branch April 15, 2022 11:59
@lchrusciel lchrusciel mentioned this pull request Apr 16, 2022
Merged
lchrusciel added a commit that referenced this pull request Apr 16, 2022
@lchrusciel
minor #435 [Maintenance] Removal of Sf4.4 BC layer leftovers (lchrusc…
a303971 
…iel)

This PR was merged into the 1.10 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | Update of #401 after #430
| License         | MIT


Commits
-------

dfd1eb3 [Maintenance] Removal of Sf4.4 BC layer leftovers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loic425 @lchrusciel