Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change all MasterRequest calls to MainRequest #332

Merged
merged 2 commits into from
Dec 21, 2021
Merged

Change all MasterRequest calls to MainRequest #332

merged 2 commits into from
Dec 21, 2021

Conversation

Roshyo
Copy link
Contributor

@Roshyo Roshyo commented Oct 27, 2021

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@Roshyo Roshyo requested a review from a team as a code owner October 27, 2021 10:12
@Zales0123 Zales0123 added DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). labels Dec 20, 2021
lchrusciel
lchrusciel approved these changes Dec 20, 2021
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is their a way to test this behaviour?

@Roshyo
Copy link
Contributor Author

Roshyo commented Dec 21, 2021

I think that running pipe through Symfony 6 should be enough as it is removed there

@loic425
Copy link
Member

loic425 commented Dec 21, 2021

I think that running pipe through Symfony 6 should be enough as it is removed there

I agree with you

@Zales0123 Zales0123 merged commit 71d13ba into Sylius:master Dec 21, 2021
@Zales0123
Copy link
Member

Thanks, Stephane! 🎉

@loic425 loic425 mentioned this pull request Mar 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loic425 loic425 loic425 approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

@Zales0123 Zales0123 Zales0123 approved these changes

Assignees
No one assigned
Labels
DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Roshyo @loic425 @Zales0123 @lchrusciel