Manage address/name recipients array in SymfonyMailerAdapter

[lanfisis]

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Related tickets	no
License	MIT

Context

I'm currently working on the upgrade of a Sylius v1.10 to Sylius 1.12. Since Sylius use Symfony Mailer instead of Swift Mailer, we encounter the following bug: before the upgrade, we use

['[email protected]' => 'John Doe', '[email protected]' => 'Jane Smith']

array for the $recipients parameter of the \Sylius\Component\Mailer\Sender\Sender::send method, and it was working like a charm.

Problem

After the upgrade, Symfony Mailer \Symfony\Component\Mime\Email object used in \Sylius\Bundle\MailerBundle\Sender\Adapter\SymfonyMailerAdapter::sendMessage is looking for a \Symfony\Component\Mime\Address objects or strings. With an array like above, it tries to use 'John Doe' or 'Jane Smith' as email and the following exception is thrown:

Fix

I've added a function to format address => name like array value to an Address object. Only address value are not touched.

[GSadee]

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "3.0" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

[GSadee]

Thank you, David! 🎉