Improve the build and fix it in the same time 🖖 #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Zales0123
commented
Dec 1, 2022
Zales0123
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
lchrusciel
approved these changes
Jan 2, 2023
GSadee
added a commit
that referenced
this pull request
Jan 9, 2023
This PR was merged into the 2.1 branch. Discussion ---------- | Q | A | --------------- | ----- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | it probably need [this](#184) to be merged before for the green build | License | MIT While the default configuration-based email creation is sufficient in most cases, it's not uncommon for one to need it conditional or dynamic in any other way. I thought about modifying the EmailProvider::getEmail(string $code)` method to accept the `array $data` argument, but thought it would be more extendible to provide a set of _modifiers_ services, that could be easily implemented in the application. Maybe it should also contain the `support(EmailInterface $email): bool` method, to not force checking the email code inside the `modify` method 🤔 Let me know what you think about such a feature 🖖 I will add some documentation to this feature if we would like to proceed with it 🫡 Commits ------- 8459e7e Test email modification 8253cb8 Use composite email modifier in Sender cdfefa0 Implement test email modifier to test the new functionality 1574bc7 CS fixes 9f40a59 Use already existing assertion for sender email d837ca7 Pass email data as modifiers factors 56ea3ee Temporarily supress psalm error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.