Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DX] Usable test application #128

Merged
merged 3 commits into from
May 10, 2022
Merged

Conversation

Zales0123
Copy link
Member

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

Let's finally move from the XIX century to the modern era 🚀 I've also added the lint:container command to ensure the configuration is runnable 🖖

@Zales0123 Zales0123 added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). DX labels May 10, 2022
@Zales0123 Zales0123 requested a review from a team as a code owner May 10, 2022 13:48
src/Bundle/test/src/Kernel.php Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved

return [
Symfony\Bundle\FrameworkBundle\FrameworkBundle::class => ['all' => true],
Sylius\Bundle\MailerBundle\SyliusMailerBundle::class => ['all' => true],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this bundle be the last one in the array?

@GSadee GSadee merged commit ac1af41 into Sylius:master May 10, 2022
@GSadee
Copy link
Member

GSadee commented May 10, 2022

Thank you, Mateusz! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants