Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GridBuilder] Apply transition action #305

Merged
merged 1 commit into from
Jun 8, 2023
Merged

[GridBuilder] Apply transition action #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions src/Bundle/Builder/Action/ApplyTransitionAction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
<?php

/*
* This file is part of the Sylius package.
*
* (c) Paweł Jędrzejewski
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

declare(strict_types=1);

namespace Sylius\Bundle\GridBundle\Builder\Action;

final class ApplyTransitionAction
{
public static function create(string $name, string $route, array $routeParameters = [], array $options = []): ActionInterface
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would still add transition and graph fields, as they would be usually used (looking at Sylius example)

Suggested change
public static function create(string $name, string $route, array $routeParameters = [], array $options = []): ActionInterface
public static function create(string $name, string $route, array $routeParameters = [], string $graph = 'default', ?string $transition = null, array $options = []): ActionInterface

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't work with symfony workflow, cause default value is null

{
$action = Action::create($name, 'apply_transition');

$options = array_merge([
'link' => [
'route' => $route,
'parameters' => $routeParameters,
],
'transition' => $name,
], $options);

$action->setOptions($options);

return $action;
}
}
72 changes: 72 additions & 0 deletions src/Bundle/spec/Builder/Action/ApplyTransitionActionSpec.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
<?php

/*
* This file is part of the Sylius package.
*
* (c) Paweł Jędrzejewski
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

declare(strict_types=1);

namespace spec\Sylius\Bundle\GridBundle\Builder\Action;

use PhpSpec\ObjectBehavior;
use Sylius\Bundle\GridBundle\Builder\Action\ActionInterface;
use Sylius\Bundle\GridBundle\Builder\Action\ApplyTransitionAction;

final class ApplyTransitionActionSpec extends ObjectBehavior
{
function it_is_initializable(): void
{
$this->shouldHaveType(ApplyTransitionAction::class);
}

function it_builds_apply_transition_actions(): void
{
$action = $this::create('publish', 'app_book_publish', ['id' => 'resource.id']);

$action->shouldHaveType(ActionInterface::class);
$action->toArray()->shouldReturn([
'type' => 'apply_transition',
'options' => [
'link' => [
'route' => 'app_book_publish',
'parameters' => ['id' => 'resource.id'],
],
'transition' => 'publish',
],
]);
}

function it_builds_apply_transition_with_options(): void
{
$action = $this::create(
'publish',
'app_book_publish',
[
'id' => 'resource.id',
],
[
'class' => 'green',
'graph' => 'sylius_book_publishing',
],
);

$action->shouldHaveType(ActionInterface::class);
$action->toArray()->shouldReturn([
'type' => 'apply_transition',
'options' => [
'link' => [
'route' => 'app_book_publish',
'parameters' => ['id' => 'resource.id'],
],
'transition' => 'publish',
'class' => 'green',
'graph' => 'sylius_book_publishing',
],
]);
}
}