Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memberOf definition #291

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Fix memberOf definition #291

merged 1 commit into from
Jan 11, 2023

Conversation

TheMilek
Copy link
Member

@TheMilek TheMilek commented Jan 2, 2023

Fixing #282

@TheMilek TheMilek added the DX Issues and PRs aimed at improving Developer eXperience. label Jan 2, 2023
@TheMilek TheMilek marked this pull request as draft January 2, 2023 15:46
@TheMilek TheMilek force-pushed the fix-memberof-method-definition branch 6 times, most recently from 325a085 to 706dd2d Compare January 3, 2023 07:43
@TheMilek TheMilek marked this pull request as ready for review January 3, 2023 07:46
GSadee
GSadee reviewed Jan 9, 2023
View reviewed changes
src/Component/Filter/StringFilter.php Outdated Show resolved Hide resolved
src/Component/Filter/StringFilter.php Outdated Show resolved Hide resolved
src/Component/Data/MemberOfAwareExpressionBuilderInterface.php Outdated Show resolved Hide resolved
src/Bundle/Doctrine/ORM/ExpressionBuilder.php Outdated Show resolved Hide resolved
src/Bundle/Doctrine/PHPCRODM/ExpressionBuilder.php Outdated Show resolved Hide resolved
@TheMilek TheMilek force-pushed the fix-memberof-method-definition branch from 706dd2d to 1f641ae Compare January 10, 2023 08:40
NoResponseMate
NoResponseMate approved these changes Jan 10, 2023
View reviewed changes
src/Component/Filter/StringFilter.php Outdated Show resolved Hide resolved
@TheMilek TheMilek force-pushed the fix-memberof-method-definition branch from 1f641ae to 9753387 Compare January 10, 2023 10:20
@TheMilek TheMilek force-pushed the fix-memberof-method-definition branch from 9753387 to fb5e0a4 Compare January 10, 2023 10:21
@GSadee GSadee merged commit d527248 into Sylius:1.13 Jan 11, 2023
@GSadee
Copy link
Member

GSadee commented Jan 11, 2023

Thanks, Kamil! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coldic3 coldic3 coldic3 left review comments

@GSadee GSadee GSadee approved these changes

@NoResponseMate NoResponseMate NoResponseMate approved these changes

@Rafikooo Rafikooo Rafikooo approved these changes

Assignees
No one assigned
Labels
DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TheMilek @GSadee @NoResponseMate @coldic3 @Rafikooo