Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making address templates uniform and easier to centrally extend. #881

Merged
merged 2 commits into from
Jan 23, 2014

Conversation

Richtermeister
Copy link
Contributor

Currently there is some duplication with regards to address (show and form) templates. There is also some cross-usage of Frontend templates in the Backend. Lastly, the company field was not (officially) part of the form yet.

This PR adds central templates for address form and show, and extends them for Frontend and Backend separately, so each can easily be customized.

@Richtermeister
Copy link
Contributor Author

While on subject, it seems fairly standard for a second address line to exist.. is this something I should add here while I am at it?

@winzou
Copy link
Contributor

winzou commented Jan 22, 2014

Yes, definitely!
Nice job, this had to be done.

@Richtermeister
Copy link
Contributor Author

@Arn0d It does, but they were not used by Sylius and also slightly different, so I left that as is for now.

@arnolanglade
Copy link
Contributor

I just have a quick look, isn't it possible to move some templates to addressing bundle? or make some macro?

@arnolanglade
Copy link
Contributor

@Richtermeister : ok

@Richtermeister
Copy link
Contributor Author

@winzou It seems the Travis build has stalled again. How did you restart it last time? I don't want to have to keep bothering you :)

@winzou
Copy link
Contributor

winzou commented Jan 23, 2014

There is a "refresh" icon on the right of this page: https://travis-ci.org/Sylius/Sylius/builds/17459926
It has already been restarted so you may have already found it ;)

pjedrzejewski pushed a commit that referenced this pull request Jan 23, 2014
Making address templates uniform and easier to centrally extend.
@pjedrzejewski pjedrzejewski merged commit b5bcd5c into Sylius:master Jan 23, 2014
@pjedrzejewski
Copy link
Member

Thanks Daniel!

@Richtermeister Richtermeister deleted the central-address-template branch January 23, 2014 16:52
@Richtermeister
Copy link
Contributor Author

@winzou Aah, thanks. Turned out I had not linked my GitHub account to Travis yet. Found the button! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). UX Issues and PRs aimed at improving User eXperience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants