-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making address templates uniform and easier to centrally extend. #881
Making address templates uniform and easier to centrally extend. #881
Conversation
While on subject, it seems fairly standard for a second address line to exist.. is this something I should add here while I am at it? |
Yes, definitely! |
@Arn0d It does, but they were not used by Sylius and also slightly different, so I left that as is for now. |
I just have a quick look, isn't it possible to move some templates to addressing bundle? or make some macro? |
@Richtermeister : ok |
@winzou It seems the Travis build has stalled again. How did you restart it last time? I don't want to have to keep bothering you :) |
There is a "refresh" icon on the right of this page: https://travis-ci.org/Sylius/Sylius/builds/17459926 |
Making address templates uniform and easier to centrally extend.
Thanks Daniel! |
@winzou Aah, thanks. Turned out I had not linked my GitHub account to Travis yet. Found the button! :) |
Currently there is some duplication with regards to address (show and form) templates. There is also some cross-usage of Frontend templates in the Backend. Lastly, the company field was not (officially) part of the form yet.
This PR adds central templates for address form and show, and extends them for Frontend and Backend separately, so each can easily be customized.