[Behat] Rework default channel factories #4138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,8 +9,9 @@ default: | |||
| entityManager: "@doctrine.orm.entity_manager" | |||
|
|
|||
| - Sylius\Behat\Context\Setup\ChannelContext: | |||
| defaultFranceChannelFactory: "@sylius.behat.factory.default_france_channel" | |||
| defaultChannelFactory: "@sylius.behat.factory.default_channel" | |||
| sharedStorage: "@sylius.behat.shared_storage" | |||
There was a problem hiding this comment.
If some context uses SharedStorage, can we pass it as the first argument?
|
As you're messing with channel factories, I have a dream... that |
michalmarcinkowski
added
the
DX
Zales0123
force-pushed
the
differentiate-default-channel-factories
branch
2 times, most recently
from
b5b57e8 to
7ccd0e5
Compare
|
Sure, |
Zales0123
force-pushed
the
differentiate-default-channel-factories
branch
from
7ccd0e5 to
a96636c
Compare
Zales0123
force-pushed
the
differentiate-default-channel-factories
branch
from
a96636c to
b8c48f0
Compare
Zales0123
force-pushed
the
differentiate-default-channel-factories
branch
from
b8c48f0 to
88682cb
Compare
pjedrzejewski
pushed a commit
that referenced
this pull request
Feb 16, 2016
…-factories [Behat] Rework default channel factories
|
Thank you Mateusz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to mentioned issue, there are now two default channel factories:
DefaultChannelFactorycreating only empty Default channelDefaultFranceChannelFactorycreating France channel, with EUR as default currency, France shipping country and proper zone with zone member