[WIP][RFC][Cart] Cart taxes scenarios #3941

Zales0123 · 2016-01-21T14:00:58Z

Q	A
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Fixed tickets
License	MIT
Doc PR

According to awesome work of @Arminek with behat scenarios here and upcoming changes with taxes here, there are some new scenarios for dealing with taxes in cart.
Of course, they could be green after merging whole taxes-related stuff. They are not implemented yet, I'm just wondering about community feedback about theirs style, have I properly caught concept of new scenarios ;)

pjedrzejewski · 2016-01-21T14:02:49Z

features/shop/cart_with_different_taxes_for _different_zones.feature

+    Background:
+        Given that store is operating on the France channel
+        And default currency is "EUR"
+        And tax rate "EU VAT" with 23% rate belongs to "Taxable Goods" category for "EU" zone


How about: And store has "EU VAT" tax rate of 23% for "Taxable Goods" in "EU" zone
I'd use a different example here, Taxable Goods is too general, let's say it is food category or something like WDYT?

👍 I was wondering about sth conciser, but didn't know how short can it be 😄 And 👍 for more specific category

pjedrzejewski · 2016-01-21T14:12:39Z

We should be more explicit about the zone, I'd be fine with steps like:

And there is "EU" zone containing all members of European Union

I know that first step is assuming we are operating a single country store, but in these scenarios we should be more explicit so something like:

Given that store is operating via single channel of sales
And it is shipping to France, Spain and Germany
And there is "EU" zone containing all members of European Union

I think our scenario will evolve and I am just throwing random ideas here, we will improve them step by step, but we need to get rid of this old, anti-BDD style. ;)

peteward · 2016-01-22T08:19:09Z

features/shop/cart_with_different_taxes_for_different_zones.feature

+        And catalog has a product "PHP T-Shirt" priced at €100.00
+        And "PHP T-Shirt" tax category is "Clothes"
+        And catalog has a product "Symfony Mug" priced at €50.00
+        And "Symfony T-Shirt" tax category is "Mugs"


I think it should be "Symfony Mug"

peteward · 2016-01-22T08:39:16Z

Great to see these 👍

I suggest you add some scenarios that look at rounding and the calculation of tax at item / unit level as discussed by myself and @michalmarcinkowski in #3868.

Even if the default stance of Sylius doesn't agree with me, I think having scenarios that cover this are really important, and can be extended when multiple calculation strategies are implemented

michalmarcinkowski · 2016-01-22T08:43:10Z

features/shop/cart_with_multiple_tax_rates.feature

@@ -0,0 +1,30 @@
+@ui-cart
+Feature: Cart with multiple tax rates


Feature: Apply correct tax for items with different tax rates

pamil · 2016-01-22T08:43:19Z

From the implementation point of view, implementing step like this may be tough:

And "DHL" tax category is "Clothes" # DHL = Shipping method
And "Banana" tax category is "Fruits" # Banana = Product

pamil · 2016-01-22T08:44:27Z

features/shop/cart_with_shipping_fee.feature

+        And default currency is "EUR"
+        And there is user "[email protected]" identified by "password123"
+        And catalog has a product "PHP T-Shirt" priced at €100.00
+        And store has "DHL" shipping method with "€10.00" fee


We should decide whether we write prices as €0.50 or "€3.00".

michalmarcinkowski · 2016-01-22T09:20:30Z

features/shop/cart_with_different_taxes_for_different_zones.feature

+    Scenario: Proper taxes before addressing
+        Given I added product "PHP T-Shirt" to the cart
+        Then my cart taxes should be "€23.00"
+        And my cart total should be "€123.00"


IMO it's more natural to swap these two:

Then my cart total should be ... And my cart taxes should be

WDYT?

Remember to follow:

GIVEN -> WHEN -> THEN

This should be:

When I add product "PHP T-Shirt" to the cart Then my cart taxes should be "€23.00" And my cart total should be "€123.00"

Anyway, we are clearly missing some context here, because we don't know anything about the user or the zone he falls into. We probably need to say: And default tax zone is "EU" in the background.

pjedrzejewski · 2016-01-22T09:34:32Z

I left bunch of comments but I stopped to avoid creating a mess in the diff comments section, so please apply these and other suggestion and we will iterate again. Not an easy task but I think we are very close! 👍

Zales0123 · 2016-01-22T10:08:36Z

@pjedrzejewski @michalmarcinkowski @peteward @pamil Ok 😄
I've implemented part of your comments, another one will be soon. Of course I could've missed something, co feel free to point them again.
Some thoughts:

I fixed this comment by specifying tax category target (product "PHP T-Shirt" belongs to.../shipping method "DHL" belongs to..), I think it's clear enough
I think we should stay with quotation marks for prices (€10.00 -> "€10.00") ;)
👍 for avoiding "catalog" word, I just cannot decide which one is better: And there is a product "PHP T-Shirt" priced at... or And store has a product "PHP T-Shirt" priced at..., WDYT?

michalmarcinkowski · 2016-01-22T10:49:08Z

@peteward we definitely are going to have some scenarios for rounding the tax at item / unit level.

@Zales0123 as for 3. IMO And store has a product...

pjedrzejewski · 2016-01-25T15:37:51Z

features/shop/cart_with_different_taxes_for_different_zones.feature

+        And I am logged in customer
+
+    Scenario: Displaying correct tax before specifying shipping address
+        When I added product "PHP T-Shirt" to the cart


Added suggests it is a pre condition, I think it should be action (When) -> add product

lchrusciel · 2016-02-09T08:33:55Z

features/shop/cart_with_different_taxes_for_different_zones.feature

+        And product "PHP T-Shirt" belongs to "Clothes" tax category
+        And store has a product "Symfony Mug" priced at "€50.00"
+        And product "Symfony Mug" belongs to "Mugs" tax category
+        And store ships everything for free


Am I right, that shipment cost is calculated based on zone, not on item? Shouldn't we change this step to And store ships everywhere for free?

Actually we ship only to the countries/zones we specified not everywhere in the world, so everything is probably more accurate than everywhere, WDYT?

I still found everywhere much more accurate. Firstly, as I wrote before, because shipping cost is related to zone, not to item. Secondly, because in this scenario we are delivering items everywhere in the world, actually. But to me more precise, WDYT about And all store shipments are free of charge?

Actually the shipping cost can be per item, there are e.g. per item and volume based calculators :)

The step is implemented in a way that right now it takes the 'current' zone, so the shipping method is available in one zone, not everywhere.

The most appropriate step will be:
And the store ships everything for free everywhere - this step could get all zones and create free shipping method for every available zone.

And the store ships everything for free to every possible location

Still not perfect, because it is not really everywhere, it is only to zones defined, which can be 2 countries. :D

@pjedrzejewski looks like the most self describing 👍

michalmarcinkowski · 2016-02-09T22:46:23Z

@Zales0123 I suppose this can be closed?

Zales0123 · 2016-02-10T08:10:30Z

@michalmarcinkowski I think yes, as we're heading to the end of this scenarios implementation ;)

[Cart] New scenarios for cart taxation

1e2c3be

pjedrzejewski added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). RFC Discussions about potential changes or new features. labels Jan 21, 2016

Zales0123 changed the title ~~[WIP][Cart] Cart taxes scenarios~~ [WIP][RFC][Cart] Cart taxes scenarios Jan 21, 2016

pjedrzejewski reviewed Jan 21, 2016
View reviewed changes

[Cart] Steps structure and semantic fixes

adf3f9d

peteward reviewed Jan 22, 2016
View reviewed changes

michalmarcinkowski reviewed Jan 22, 2016
View reviewed changes

pamil reviewed Jan 22, 2016
View reviewed changes

michalmarcinkowski reviewed Jan 22, 2016
View reviewed changes

[Cart] Further steps changes

ac7f485

Zales0123 force-pushed the cart-taxes-scenarios branch from d8180c2 to ac7f485 Compare January 22, 2016 11:54

[Cart] Added scenarios for different users types

db6bb34

pjedrzejewski reviewed Jan 25, 2016
View reviewed changes

[Cart] Futher scenarios changes

97568a0

Zales0123 mentioned this pull request Jan 26, 2016

[Cart] Cart without taxes scenario #3986

Merged

lchrusciel reviewed Feb 9, 2016
View reviewed changes

Zales0123 closed this Feb 10, 2016

Zales0123 deleted the cart-taxes-scenarios branch October 6, 2016 20:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP][RFC][Cart] Cart taxes scenarios #3941

[WIP][RFC][Cart] Cart taxes scenarios #3941

Zales0123 commented Jan 21, 2016

pjedrzejewski Jan 21, 2016

Zales0123 Jan 21, 2016

pjedrzejewski commented Jan 21, 2016

peteward Jan 22, 2016

peteward commented Jan 22, 2016

michalmarcinkowski Jan 22, 2016

pamil commented Jan 22, 2016

pamil Jan 22, 2016

michalmarcinkowski Jan 22, 2016

pjedrzejewski Jan 22, 2016

pjedrzejewski commented Jan 22, 2016

Zales0123 commented Jan 22, 2016

michalmarcinkowski commented Jan 22, 2016

pjedrzejewski Jan 25, 2016

lchrusciel Feb 9, 2016

michalmarcinkowski Feb 9, 2016

lchrusciel Feb 9, 2016

michalmarcinkowski Feb 9, 2016

pjedrzejewski Feb 9, 2016

michalmarcinkowski Feb 9, 2016

michalmarcinkowski commented Feb 9, 2016

Zales0123 commented Feb 10, 2016

		@@ -0,0 +1,30 @@
		@ui-cart
		Feature: Cart with multiple tax rates

[WIP][RFC][Cart] Cart taxes scenarios #3941

[WIP][RFC][Cart] Cart taxes scenarios #3941

Conversation

Zales0123 commented Jan 21, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pjedrzejewski commented Jan 21, 2016

Choose a reason for hiding this comment

peteward commented Jan 22, 2016

Choose a reason for hiding this comment

pamil commented Jan 22, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pjedrzejewski commented Jan 22, 2016

Zales0123 commented Jan 22, 2016

michalmarcinkowski commented Jan 22, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

michalmarcinkowski commented Feb 9, 2016

Zales0123 commented Feb 10, 2016