Remove configuration form validation groups #3731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjedrzejewski
added
Bug Fix
DX
|
@pjedrzejewski I think you're right! This feature is an overkill, I guest it is use rarely... |
pjedrzejewski
force-pushed
the
remove-configuration-form-validation-groups
branch
3 times, most recently
from
e2c4455 to
1bce078
Compare
pjedrzejewski
force-pushed
the
remove-configuration-form-validation-groups
branch
from
1bce078 to
19ba996
Compare
michalmarcinkowski
added a commit
that referenced
this pull request
Dec 18, 2015
…-validation-groups Remove configuration form validation groups
|
I like cleanups! Thanks Paweł! 👍 |
| $validationGroups = array('Default'); | ||
| } | ||
|
|
||
| $definition->setArguments(array( | ||
| $metadata->getClass('model'), | ||
| $validationGroups, | ||
| $validationGroups |
There was a problem hiding this comment.
IMO this should be reverted ;)
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
…n-form-validation-groups Remove configuration form validation groups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #3721.
Helloes.
This change basically forces all Sylius resource forms to use Default validation group. Result:
validation_groupsconfig node is available for every single resource, thus we maintain the ability to completely rework validation.I did that for Promotion only right now, but will do this for everything else if I get support from you guys. :) Let me know what do you think!
Will be easier to review once #3721 is merged. Perhaps wait with reviewing the code.