Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usage of Symfony Polyfill components #3594

Merged
merged 1 commit into from
Nov 29, 2015

Conversation

stloyd
Copy link
Contributor

@stloyd stloyd commented Nov 20, 2015

Q A
Bug fix? yes
New feature? no
BC breaks? no
Fixed tickets #3590
License MIT

This replaces #3591.

  • iconv is used in Sylius\Component\Product\Sluggable\ProductTranslationSlugEventListener,
  • mbstring is used in i.e.: Sylius\Component\User\Canonicalizer\Canonicalizer

@michalmarcinkowski
Copy link
Contributor

@stloyd please add the extensions to suggest

@stloyd stloyd force-pushed the feature/polyfill_usage branch from c91de64 to fda1c4e Compare November 20, 2015 10:42
@cdaguerre
Copy link
Contributor

@stloyd Should also be added to Product and User component composer.json files ;)

@pjedrzejewski
Copy link
Member

I think we need to update our installer requirements and change them to suggestions as well.

@pjedrzejewski pjedrzejewski added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). DX Issues and PRs aimed at improving Developer eXperience. labels Nov 20, 2015
@pjedrzejewski pjedrzejewski added this to the v0.16.0 milestone Nov 20, 2015
@stloyd stloyd force-pushed the feature/polyfill_usage branch from fda1c4e to b5b9909 Compare November 20, 2015 11:08
@stloyd
Copy link
Contributor Author

stloyd commented Nov 20, 2015

@pjedrzejewski Extensions in installer are all marked as "optional" & product just warning from what I can see in master branch.

@stloyd stloyd force-pushed the feature/polyfill_usage branch from b5b9909 to 295071f Compare November 28, 2015 15:01
@stloyd
Copy link
Contributor Author

stloyd commented Nov 28, 2015

@pjedrzejewski @michalmarcinkowski ping

pjedrzejewski pushed a commit that referenced this pull request Nov 29, 2015
Add usage of Symfony Polyfill components
@pjedrzejewski pjedrzejewski merged commit 73257a5 into Sylius:master Nov 29, 2015
@pjedrzejewski
Copy link
Member

Thank you Joseph! 👍

@stloyd stloyd deleted the feature/polyfill_usage branch November 30, 2015 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants