[WebBundle] Form theming fix for when no label is explicitly specified #3574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing fallback of underlying attribute name. Now uses same logic as form_label block.
|
@peteward Could you take a look at the failing build? Thanks! |
|
seems fine now it's rerun |
|
@pjedrzejewski I restarted the build and it's green. Ready to merge. |
pjedrzejewski
pushed a commit
that referenced
this pull request
Nov 18, 2015
[WebBundle] Form theming fix for when no label is explicitly specified
|
Thanks Peter! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affects label placement on large resolutions.
Use the correct check for whether a label is not being used as per the default form_label block rather than checking only for a user-entered label.
Fixes #3512
BEFORE:
AFTER: