Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony update to 2.7.5 #3449

Merged
merged 2 commits into from
Nov 17, 2015
Merged

Conversation

CoderMaggie
Copy link
Member

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

Update due to the 'case mismatch' bug detected while setting up Sylius locally.
PR from Symfony: symfony/symfony#15783

@pamil
Copy link
Contributor

pamil commented Oct 16, 2015

We need to bump requirements in composer.json too.

@CoderMaggie
Copy link
Member Author

@pamil 👍

@@ -67,7 +67,7 @@
"symfony/options-resolver": "^2.7",
"symfony/property-access": "^2.7",
"symfony/swiftmailer-bundle": "^2.3",
"symfony/symfony": "^2.7",
"symfony/symfony": "^2.7.5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proper criteria should be >=2.7.5, <3.0.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I somehow saw tilde instead of caret 😄 my bad then 😉

@pjedrzejewski
Copy link
Member

@pamil Do you mean just main composer.json? (singular form) If yes, then I will add that we should adjust all component&bundle jsons.

@CoderMaggie
Copy link
Member Author

@pjedrzejewski I'll take care of it ASAP :)

@CoderMaggie
Copy link
Member Author

Okay @pjedrzejewski I've updated all symfony/framework-bundle dependencies in bundles' jsons. :)

pjedrzejewski pushed a commit that referenced this pull request Nov 17, 2015
@pjedrzejewski pjedrzejewski merged commit 7884469 into Sylius:master Nov 17, 2015
@pjedrzejewski
Copy link
Member

Thank you Magda!

@CoderMaggie CoderMaggie deleted the symfony-update branch April 6, 2016 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants