[Core] Add missing spec for ContainsProductRuleChecker #3340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PWalkow
commented
Sep 23, 2015
PWalkow
commented
| Q | A |
|---|---|
| Bug fix? | [no] |
| New feature? | [no] |
| BC breaks? | [no] |
| Deprecations? | [no] |
| Fixed tickets | [] |
| License | MIT |
| Doc PR | [missing Specs for RuleChecker] |
PWalkow
force-pushed
the
add-missing-spec-for-contains-product-rule-checker
branch
from
0197dec to
76ce9ec
Compare
PWalkow
changed the title
PWalkow
force-pushed
the
add-missing-spec-for-contains-product-rule-checker
branch
from
76ce9ec to
4275c5a
Compare
| $this->shouldImplement('Sylius\Component\Promotion\Checker\RuleCheckerInterface'); | ||
| } | ||
|
|
||
| function it_throw_exception_on_invalid_subject(PromotionSubjectInterface $subject) |
PWalkow
force-pushed
the
add-missing-spec-for-contains-product-rule-checker
branch
from
4275c5a to
4d3201e
Compare
| OrderItem $orderItem, | ||
| ProductVariant $variant | ||
| ) { | ||
| $subject->getItems()->shouldBeCalled()->willReturn([$orderItem]); |
There was a problem hiding this comment.
shouldBeCalled() is useless when you use willReturn(). Don't use mocks & stubs to test same thing!
There was a problem hiding this comment.
shouldBeCalled() says explicitly that some method should be called (spec should be as readable as possible) and gives us faster and direct feedback if something that should be called hasn't been called.
There was a problem hiding this comment.
Then you misunderstand purposes of those two things, I have already explained it some time ago but don't have time now to do this again (as well for looking across the PRs to find those notes), please read:
- http://adamwathan.me/2014/09/22/when-to-mock/
- some parts of this http://everzet.com/post/33178339051/sus-collaborators cover that topic too
PWalkow
force-pushed
the
add-missing-spec-for-contains-product-rule-checker
branch
from
4d3201e to
abe6d7a
Compare
|
Removed 'shouldBeCalled' |
pjedrzejewski
pushed a commit
that referenced
this pull request
Oct 21, 2015
…roduct-rule-checker [Core] Add missing spec for ContainsProductRuleChecker
|
Thanks @PWalkow! |
PWalkow
deleted the
add-missing-spec-for-contains-product-rule-checker
branch
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
…ains-product-rule-checker [Core] Add missing spec for ContainsProductRuleChecker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.