[WebBundle] Properly close javascripts block and remove superfluous endblock #2238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rskuipers
changed the title
pjedrzejewski
pushed a commit
that referenced
this pull request
Dec 9, 2014
[WebBundle] Properly close javascripts block and remove superfluous endblock
|
Oops, thank you @rskuipers, I'm glad we are getting rid of this frontend soon. :) |
|
@pjedrzejewski You're welcome! Out of curiosity, what part are you getting rid of? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the javascripts block was moved to the top at some point but the endblock was never moved with it.
The whole body of the layout was in the javascripts block.