Fix gaufrette version #1283
Fix gaufrette version #1283
Conversation
This resolve conflict after KnpLabs/KnpGaufretteBundle@f330085 PR
|
Do we use gaufrette directly in Sylius? Otherwise we should have only dependency on the bundle. |
| @@ -41,7 +41,7 @@ | |||
| "sylius/resource-bundle": "0.9.*@dev", | |||
| "friendsofsymfony/user-bundle": "2.0.*@dev", | |||
| "jms/serializer-bundle": "0.12.*", | |||
| "knplabs/gaufrette": "0.2.*@dev", | |||
| "knplabs/gaufrette": "~0.1.7", | |||
There was a problem hiding this comment.
Should be completly removed, if the bundle uses a stable dependency. The dev constraint was there, to resolve conflicts, as Sylius has a stable minimum-stability.
There was a problem hiding this comment.
Also the main composer.json + lock file should be adjusted.
There was a problem hiding this comment.
@ramol Could you update your patch, please?
There was a problem hiding this comment.
What about PR #1284 and remove all gaufrette dependency?
There was a problem hiding this comment.
Oh but main composer.json don't have dependency to "knplabs/gaufrette", I can PR lock after update.
When I try update SyliusCoreBundle I got also problem with doctrine/doctrine-bundle ~1.3@dev -> no matching package found. Stof suggests doctrine/DoctrineBundle#276 (comment)
but we have dependency to doctrine/doctrine-cache-bundle in SyliusSettingsBundle. It's like spider web :D Maybe somebody else can resolve this ?
There was a problem hiding this comment.
After PR KnpLabs/KnpGaufretteBundle@ae598e6 we don't need to change anything with Gaufrette and we can close this PR
Standard Edition composer update works like a charm
:D
|
Would be nice to see this through soon, can't run |
This resolve conflict after KnpLabs/KnpGaufretteBundle@f330085 PR