Add fixes for behats

Sylius · Feb 10, 2020 · 9095050 · 9095050
1 parent be08c3b
commit 9095050
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 6 deletions.
diff --git a/features/shipping/managing_shipments/seeing_shipment.feature b/features/shipping/managing_shipments/seeing_shipment.feature
@@ -18,5 +18,5 @@ Feature: Seeing basic information about shipment
 
     @ui
     Scenario: Seeing basic information about shipment
-        When I view the shipment of the order "#00000001"
+        When I view the first shipment of the order "#00000001"
         Then I should see 2 "Apple" items in it
diff --git a/src/Sylius/Behat/Context/Ui/Admin/ManagingShipmentsContext.php b/src/Sylius/Behat/Context/Ui/Admin/ManagingShipmentsContext.php
@@ -107,7 +107,7 @@ public function iFilter(): void
     }
 
     /**
-     * @When I view the shipment of the order :order
+     * @When I view the first shipment of the order :order
      */
     public function iViewTheShipmentOfTheOrder(OrderInterface $order): void
     {
@@ -200,6 +200,6 @@ public function iShouldSeeShipmentForTheOrderInTheList(string $orderNumber, int
      */
     public function iShouldSeeItemsInIt(int $amountOf, ProductInterface $product): void
     {
-        $this->shipmentShowPage->hasShipmentUnit($amountOf, $product);
+        Assert::true($amountOf === $this->shipmentShowPage->getAmountOfShipmentUnits($product));
     }
 }
diff --git a/src/Sylius/Behat/Page/Admin/Shipment/ShowPage.php b/src/Sylius/Behat/Page/Admin/Shipment/ShowPage.php
@@ -23,11 +23,11 @@ public function getRouteName(): string
         return 'sylius_admin_shipment_show';
     }
 
-    public function hasShipmentUnit(int $amountOf, ProductInterface $product): bool
+    public function getAmountOfShipmentUnits(ProductInterface $product): int
     {
         $table = $this->getElement('shipment_table');
 
-        return $amountOf === count($table->findAll('css', sprintf('td:contains("%s")', $product->getName())));
+        return count($table->findAll('css', sprintf('td:contains("%s")', $product->getName())));
     }
 
     protected function getDefinedElements(): array

diff --git a/src/Sylius/Behat/Page/Admin/Shipment/ShowPageInterface.php b/src/Sylius/Behat/Page/Admin/Shipment/ShowPageInterface.php
@@ -18,5 +18,5 @@
 
 interface ShowPageInterface extends PageInterface
 {
-    public function hasShipmentUnit(int $amountOf, ProductInterface $product): bool;
+    public function getAmountOfShipmentUnits(ProductInterface $product): int;
 }
diff --git a/src/Sylius/Bundle/AdminBundle/Resources/views/Shipment/Grid/_ship.html.twig b/src/Sylius/Bundle/AdminBundle/Resources/views/Shipment/Grid/_ship.html.twig
@@ -6,3 +6,4 @@
 </div>
 {{ form_row(form._token) }}
 {{ form_end(form, {'render_rest': false}) }}
+src/Sylius/Behat/Context/Ui/Admin/ManagingShipmentsContext.php