Add Docker setup #232
Add Docker setup #232
Conversation
| host: '%database_host%' | ||
| port: '%database_port%' | ||
| dbname: '%database_name%' | ||
| user: '%database_user%' | ||
| password: '%database_password%' | ||
| driver: pdo_mysql |
There was a problem hiding this comment.
It's pointless to have database driver configurable via environment variable when the server_version is fixed here. It's also something that does not change across deployments in an application, so following Symfony Best Practices:
Application-Related Configuration
Define the application behavior related configuration options in the
app/config/config.ymlfile.Defining these values in
parameters.ymlfile would add an extra layer of configuration that's not needed because you don't need or want these configuration values to change on each server.
teohhanhui
force-pushed
the
add/docker-setup
branch
4 times, most recently
from
490ff7a
to
857a00f
Compare
| @@ -81,7 +81,7 @@ | |||
| "symfony-var-dir": "var", | |||
| "symfony-web-dir": "web", | |||
| "symfony-tests-dir": "tests", | |||
| "symfony-assets-install": "relative", | |||
| "symfony-assets-install": "copy", | |||
There was a problem hiding this comment.
This is necessary as symlinks don't work across containers.
| ports: | ||
| - "80:80" | ||
|
|
||
| mailhog: |
There was a problem hiding this comment.
It's unfortunate that we've set
swiftmailer:
disable_delivery: truein the dev and staging environments, where this would be useful.
So the user will have to change this value manually in the config files, if they use something like Mailhog.
SwiftmailerBundle does not support using an environment variable for disable_delivery, similar to symfony/swiftmailer-bundle#159
teohhanhui
force-pushed
the
add/docker-setup
branch
from
857a00f
to
0e539df
Compare
* 1.2: Update to Sylius v1.2.0-RC Remove vendorPath command-line argument from root gulpfile
* 1.2: Update composer lockfile Remove Selenium and PerformanceExtension from dependencies
* 1.2: Upgrade Composer & Yarn dependencies Upgrade Composer & Yarn dependencies Upgrade Composer & Yarn dependencies
teohhanhui
force-pushed
the
add/docker-setup
branch
from
0e539df
to
060fd80
Compare
* 1.2: Update to Sylius v1.1.7 Update to Sylius v1.0.16 Update to Sylius v1.2.0
* 1.2: Test against both Symfony 3.4 and 4.1
teohhanhui
force-pushed
the
add/docker-setup
branch
from
060fd80
to
5b90e85
Compare
|
Sure, and I'll have to do a rebase. You used the awful GitHub "update branch" button which |
TODO: