forked from visoftsolutions/noir_rs
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor(avm): avm memory trace building (AztecProtocol#3835)
Resolves AztecProtocol#3834 Moving all AVM memory related trace building functions into a dedicated class. Furthermore, all AVM related trace files were moved into a dedicated folder in vm. The following files: - AvmMini_common.hpp - AvmMini_helper.cpp - AvmMini_helper.hpp - AvmMini_mem_trace.cpp - AvmMini_mem_trace.hpp - AvmMini_trace.cpp - AvmMini_trace.hpp were moved from barretenberg/cpp/src/barretenberg/proof_system/circuit_builder/ to barretenberg/cpp/src/barretenberg/vm/avm_trace/ Finally, the namespace for these files were migrating from proof_system to avm_trace.
- Loading branch information
Showing
14 changed files
with
1,100 additions
and
992 deletions.
There are no files selected for viewing
743 changes: 0 additions & 743 deletions
743
barretenberg/cpp/src/barretenberg/proof_system/circuit_builder/AvmMini_trace.cpp
This file was deleted.
Oops, something went wrong.
114 changes: 0 additions & 114 deletions
114
barretenberg/cpp/src/barretenberg/proof_system/circuit_builder/AvmMini_trace.hpp
This file was deleted.
Oops, something went wrong.
14 changes: 7 additions & 7 deletions
14
...system/circuit_builder/AvmMini_helper.hpp → ...retenberg/vm/avm_trace/AvmMini_common.hpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,17 @@ | ||
#pragma once | ||
|
||
#include "barretenberg/ecc/curves/bn254/fr.hpp" | ||
#include "barretenberg/proof_system/circuit_builder/circuit_builder_base.hpp" | ||
|
||
#include "barretenberg/flavor/generated/AvmMini_flavor.hpp" | ||
#include "barretenberg/proof_system/circuit_builder/generated/AvmMini_circuit_builder.hpp" | ||
|
||
namespace proof_system { | ||
|
||
using Flavor = proof_system::honk::flavor::AvmMiniFlavor; | ||
using FF = Flavor::FF; | ||
using Row = proof_system::AvmMiniFullRow<barretenberg::fr>; | ||
|
||
void log_avmMini_trace(std::vector<Row> const& trace, size_t beg, size_t end); | ||
namespace avm_trace { | ||
|
||
// Number of rows | ||
static const size_t AVM_TRACE_SIZE = 256; | ||
enum class IntermRegister : uint32_t { ia = 0, ib = 1, ic = 2 }; | ||
enum class AvmMemoryTag : uint32_t { u0 = 0, u8 = 1, u16 = 2, u32 = 3, u64 = 4, u128 = 5, ff = 6 }; | ||
|
||
} // namespace proof_system | ||
} // namespace avm_trace |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
barretenberg/cpp/src/barretenberg/vm/avm_trace/AvmMini_helper.hpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
#pragma once | ||
|
||
#include "AvmMini_common.hpp" | ||
|
||
namespace avm_trace { | ||
|
||
void log_avmMini_trace(std::vector<Row> const& trace, size_t beg, size_t end); | ||
|
||
} // namespace avm_trace |
Oops, something went wrong.