Skip to content

Commit

Permalink
fix: use go install instead of go get in makefile (cosmos#12435)
Browse files Browse the repository at this point in the history
  • Loading branch information
julienrbrt authored and randy75828 committed Aug 10, 2022
1 parent f735d2f commit 0473558
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
run: go version
- name: install tparse
run: |
export GO111MODULE="on" && go get github.com/mfridman/[email protected]
go install github.com/mfridman/[email protected]
- uses: actions/[email protected]
with:
path: ~/go/bin
Expand Down
18 changes: 5 additions & 13 deletions contrib/devtools/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -57,28 +57,20 @@ tools-stamp: statik runsim
# in a row.
touch $@

# Install the runsim binary with a temporary workaround of entering an outside
# directory as the "go get" command ignores the -mod option and will polute the
# go.{mod, sum} files.
#
# ref: https://github.com/golang/go/issues/30515
# Install the runsim binary
statik: $(STATIK)
$(STATIK):
@echo "Installing statik..."
@(cd /tmp && go get github.com/rakyll/[email protected])
@go install github.com/rakyll/[email protected]

# Install the runsim binary with a temporary workaround of entering an outside
# directory as the "go get" command ignores the -mod option and will polute the
# go.{mod, sum} files.
#
# ref: https://github.com/golang/go/issues/30515
# Install the runsim binary
runsim: $(RUNSIM)
$(RUNSIM):
@echo "Installing runsim..."
@(cd /tmp && go get github.com/cosmos/tools/cmd/[email protected])
@go install github.com/cosmos/tools/cmd/[email protected]

tools-clean:
rm -f $(STATIK) $(GOLANGCI_LINT) $(RUNSIM)
rm -f tools-stamp

.PHONY: tools-clean statik runsim
.PHONY: tools-clean statik runsim

0 comments on commit 0473558

Please sign in to comment.