fix(competitions): deduce last edition using the start date instead o…

…f the given order
SwissTchoukball · May 25, 2024 · c9bb464 · c9bb464
1 parent 821f37f
commit c9bb464
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/models/competition.model.ts b/models/competition.model.ts
@@ -20,7 +20,8 @@ export default class Competition {
       return null;
     }
 
-    // FIXME: This is a naive selection of the last edition. It might not work, i.e. when adding older editions.
-    return this.editions[this.editions.length - 1];
+    return this.editions.reduce((lastEdition, edition) => {
+      return edition.season.date_start > lastEdition.season.date_start ? edition : lastEdition;
+    });
   }
 }
diff --git a/plugins/cms-service.ts b/plugins/cms-service.ts
@@ -1934,7 +1934,7 @@ const cmsService: Plugin = (context, inject) => {
             editions: [
               'leverade_id',
               {
-                season: ['id', 'name', 'slug', 'leverade_id'],
+                season: ['id', 'name', 'slug', 'leverade_id', 'date_start'],
               },
             ],
           },