fix(core): automatically cleanup dangling git processes #2928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panaetius
changed the title
Panaetius
force-pushed
the
bugfix/2889-cleanup-dangling-gitpython
branch
from
153d4ac to
a9903f4
Compare
m-alisafaee
reviewed
May 30, 2022
Panaetius
force-pushed
the
bugfix/2889-cleanup-dangling-gitpython
branch
3 times, most recently
from
1e52199 to
658b53d
Compare
Panaetius
force-pushed
the
bugfix/2889-cleanup-dangling-gitpython
branch
from
658b53d to
edd29e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2889
Fixes a bug where SubmoduleManager would create a new Repository on each access, which in turn would have a dangling git subprocess.
Force cleans/deletes the repository in many cases where it makes sense, reducing the risk of dangling processes