Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger schema doesn't include max-query-timeout #531

Closed
Robsteranium opened this issue May 19, 2021 · 0 comments · Fixed by #532
Closed

Swagger schema doesn't include max-query-timeout #531

Robsteranium opened this issue May 19, 2021 · 0 comments · Fixed by #532
Labels
drafter-client Issue related to drafter-client

Comments

@Robsteranium
Copy link
Contributor

This in turn means that the Martian client won't add this to the request - it's ignored if if you pass it as a keyword argument (to e.g. post-query-live).

We could do with permitting the OOK etl pipeline to run with a longer timeout because truncation of results can go undetected.

The only way to do this at the moment is with the JWS-signed max-query-timeout parameter. Ultimately we ought to rework the timeout authorisation to use auth0 with some sort of drafter:privileged permission #357.

In the meantime it'd be good to at least extend the swagger schema to support the legacy behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
drafter-client Issue related to drafter-client
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant