Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated iOS framework to Swift 4.2 #110

Closed
wants to merge 1 commit into from
Closed

Updated iOS framework to Swift 4.2 #110

wants to merge 1 commit into from

Conversation

JacobMao
Copy link

@JacobMao JacobMao commented Oct 2, 2018

When you upgrade to Swift 4.2, the childViewControllers has renamed to children in iOS

@JacobMao JacobMao mentioned this pull request Oct 2, 2018
Merged
@jakubvano
Copy link
Member

Thanks for the PR @JacobMao! 👍
However, I will close this, because source code changes have been included in #109, and there were some additional updates to tests required (see #111)

@jakubvano jakubvano closed this Oct 3, 2018
@jakubvano jakubvano added this to the 2.1.0 milestone Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JacobMao @jakubvano