Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr looks ugly but it is not.
It adds thread safety to the register to solve a race condition.
SynchronizedResolver
toSynchronizedContainer
_Register
andRegister
and I moved_register
andregister
functions fromContainer
to them.Register
protocol inSynchronizedContainer
and make it use the sameNSLock
object to make register calls thread safe.Sources/SynchronizedContainer.Arguments.erb
and ranscript/gencode
, there is where most of the changes come from.