This repository has been archived by the owner on Sep 6, 2018. It is now read-only.
Swiftlint rules in color templates #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Thank you for the contribution! A quick tip for those failing tests: you can run them locally using either the xcode project (use the CMD + U shortcut), or in terminal using |
|
Thanks for the tip 👍🏻 |
djbe
reviewed
Apr 4, 2017
CHANGELOG.md
Outdated
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| ### Bug Fixes | |||
|
|
|||
| _None_ | |||
| * Fixed `swiftlint` warnings in generated color extensions | |||
There was a problem hiding this comment.
Please use the same format as the other entries:
- credit yourself
- add a link to this PR
- a
.at the end of the sentence and 2 spaces
djbe
suggested changes
Apr 4, 2017
djbe
reviewed
Apr 4, 2017
CHANGELOG.md
Outdated
| @@ -6,7 +6,9 @@ | |||
|
|
|||
| ### Bug Fixes | |||
|
|
|||
| _None_ | |||
| * Fixed `swiftlint` warnings in generated color extensions. | |||
| [Roman Laitarenko](https://github.com/evil159) | |||
There was a problem hiding this comment.
Hate to be nitpicky here, but please indent the username and PR links.
djbe
approved these changes
Apr 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was inconsistency in
swiftlintrules:file_length, andline_lengthwere disabled but not enabled back(probably not a big deal, just a minor thing).Another thing was that vertical alignment of variables inside
Colorextension initialiser causedswiftlintto emit a warning based onoperator_usage_whitespacerule, fixed it by disabling this rule for theColorextension.