This repository has been archived by the owner on Sep 6, 2018. It is now read-only.
Deprecated variables #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Todo: adapt the strings templates to at least use the new |
|
Wait until #24 is merged before merging this. |
djbe
force-pushed
the
feature/deprecated-variables
branch
from
b122802
to
4c29ec1
Compare
|
I've adapted the tests to not use the We can't delete the files yet though, because we still need to test these in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better deprecation of
strings.paramsandstrings/structuredStrings.Works together with SwiftGen/SwiftGenKit#12.