This repository has been archived by the owner on Sep 6, 2018. It is now read-only.
Strings: rename some vars for clarity purposes #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- strings --> levels - subenums --> children - keytail --> name
AliSoftware
reviewed
May 7, 2017
| @@ -67,7 +70,7 @@ extension StringsFileParser { | |||
| ) | |||
| let tables: [[String: Any]] = [[ | |||
| "name": tableName, | |||
| "strings": structuredStrings | |||
| "levels": structuredStrings | |||
There was a problem hiding this comment.
Shouldn't we keep the strings entry too (duplicate of levels) for 4.2.1 until we can remove it in 5.0.0, at least f we want to merge that for 4.2.1?
There was a problem hiding this comment.
Lemme check, but I don't think tables.strings was ever released.
There was a problem hiding this comment.
Ah, good point, maybe not ^^
There was a problem hiding this comment.
Jup, never released:
(that's SwiftGenKit 1.0.1)
AliSoftware
reviewed
May 8, 2017
Sources/Stencil/StringsContext.swift
Outdated
| - `name` : `String` — name of the `.strings` file (usually `"Localizable"`) | ||
| - `levels`: `Array` — Tree structure of strings (based on dot syntax), each level has: | ||
| - `name` : `String` — name of the level (that is, part of the key split by `.` that we're describing) | ||
| - `children`: `Array` — list of sub-levels, repeating the structure mentioned above |
There was a problem hiding this comment.
Mentioned below?
Repeating the same structure as a level?
Sources/Stencil/StringsContext.swift
Outdated
| @@ -37,8 +37,11 @@ extension StringsFileParser { | |||
| let keytail = keyStructure.joined(separator: ".") | |||
There was a problem hiding this comment.
Maybe rename the variable as well in the code for consistency?
Sources/Stencil/StringsContext.swift
Outdated
| @@ -135,6 +138,9 @@ extension StringsFileParser { | |||
| } | |||
|
|
|||
| if !subenums.isEmpty { | |||
There was a problem hiding this comment.
Maybe rename the variable in the code too for consistency
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #5
Related to SwiftGen/templates#43