-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fonts: parameters to change typealias name & struct name #728
Conversation
Hey 👋 I'm Eve, the friendly bot watching over SwiftGen 🤖 Thanks a lot for your contribution! Seems like everything is in order 👍 You did a good job here! 🤝 Generated by 🚫 Danger |
2d550a0
to
4e30429
Compare
122f535
to
0a5a99c
Compare
I don't think this is the best approach, because in other templates we've migrated away from those top-level So I think a better approach would be to remove those top-level |
You're right, why did I not think of that 🤦
Note that I've rebased all commits, as this is a full rework of the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a conjugation typo and indent Q otherwise LGTM 👌
Fixes #647.
Mirrors the implementation from the
xcassets
templates.