Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snakeToCamelCase readme documentation #45

Merged
merged 2 commits into from
May 20, 2017

Conversation

Liquidsoul
Copy link
Member

I've noticed that the information about snakeToCamelCase's parameter in the README is wrong so this PR fixes this.
I've also added some tests to show that and ensure that I was not mistaking 😅

The valid options are "true", "yes" or "1" not "true", "no" or "0".
@Liquidsoul Liquidsoul force-pushed the fix/snakeToCamelCase-readme-documentation branch from c416895 to 2a3c27f Compare May 19, 2017 20:02
@djbe
Copy link
Member

djbe commented May 19, 2017

Should we repeat those tests though? Aren't those cases already covered by the parseBool tests?

@Liquidsoul
Copy link
Member Author

Maybe not. I'll remove the added tests in the PR.

@Liquidsoul Liquidsoul force-pushed the fix/snakeToCamelCase-readme-documentation branch from 2a3c27f to 4a33436 Compare May 20, 2017 09:24
@Liquidsoul Liquidsoul force-pushed the fix/snakeToCamelCase-readme-documentation branch from 4a33436 to 5890264 Compare May 20, 2017 09:25
@djbe djbe merged commit 62c62b6 into master May 20, 2017
@djbe djbe deleted the fix/snakeToCamelCase-readme-documentation branch May 20, 2017 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants