Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert project to SPM #130

Merged
merged 6 commits into from
Feb 7, 2021
Merged

Convert project to SPM #130

merged 6 commits into from
Feb 7, 2021

Conversation

djbe
Copy link
Member

@djbe djbe commented Oct 14, 2020

Similar to SwiftGen/SwiftGen#793, but much simpler in scope as we already have full SPM support in this project.

This just:

  • Removes the old Xcode projects
  • Removes CocoaPods (as a dependency/tool)
  • Use commit hooks (Komondor) to run SwiftLint
  • Adapts Rake and CI as needed

@djbe djbe force-pushed the feature/compile-via-spm branch from 9ee5bba to 94bb885 Compare October 14, 2020 20:41
@djbe djbe force-pushed the feature/compile-via-spm branch from 94bb885 to 644e5e3 Compare October 25, 2020 20:53
@djbe
Copy link
Member Author

djbe commented Oct 25, 2020

Allright so this is slightly weird, and I'm not sure how we should deal with it:

Do we remove that pod check from the list of required steps? What about PRs where there's no code change, such as a doc PR? Should we remove all checks from being required?

@djbe djbe force-pushed the feature/compile-via-spm branch from 644e5e3 to 1515a3a Compare November 8, 2020 22:18
@djbe djbe force-pushed the feature/compile-via-spm branch from 1515a3a to 83fa74c Compare November 17, 2020 21:50
@djbe djbe force-pushed the feature/compile-via-spm branch from 83fa74c to 1a05a43 Compare February 7, 2021 20:31
@djbe djbe merged commit dc1d1a4 into stable Feb 7, 2021
@djbe djbe deleted the feature/compile-via-spm branch February 7, 2021 20:37
@djbe djbe added this to the 2.8.0 milestone Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant