Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Swift 4.2 (or drop support for it) #128

Closed
djbe opened this issue Oct 9, 2020 · 4 comments · Fixed by #132
Closed

Test Swift 4.2 (or drop support for it) #128

djbe opened this issue Oct 9, 2020 · 4 comments · Fixed by #132
Milestone

Comments

@djbe
Copy link
Member

djbe commented Oct 9, 2020

As discussed in #127, we need to decide what to do with Swift 4.2.

Do we expect lots of people to still use Swift 4.2? Any platform that supports Swift 4.2 also supports Swift 5, so we may as well drop it?

@djbe djbe added this to the 2.8.0 milestone Oct 9, 2020
@djbe
Copy link
Member Author

djbe commented Oct 9, 2020

Anyone got strong opinions on this one? Otherwise we might as wel drop it.

The main project, besides SwiftGen, that uses SSK is Sourcery, and they're on Swift 5.

@fortmarek
Copy link
Member

It seems there are no strong opinions on this one - I think it'd be fine to drop it. If you want to, I can create a PR for this - and afterwards it'd make sense to create the 2.8.0 release?

@djbe
Copy link
Member Author

djbe commented Nov 3, 2020

Yes definitely 👍

I'm hoping to merge #130 as well for 2.8.0, but it isn't a blocker. We can always merge that one afterwards.

@schemers
Copy link

schemers commented Dec 9, 2020

Is there a timeline on a 2.8.0 release? Using .branch("stable") seems to be causing some heartburn to SPM that I wasn't encountering when using version number. 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants