-
Notifications
You must be signed in to change notification settings - Fork 29
Conversation
The CI failure is due to the 5.4 release of swift-syntax missing a change. I've created swiftlang/swift-syntax#283 to back port the fix for 5.4. We will need to bump the dependency for Windows 5.4 support, but 5.5 should be fine. CC: @mattt |
Add coverage for Windows with Swift 5.4
@compnerd I'm really sorry if I wiped out your changes with #15 (comment). I wanted to rebase against latest |
@mattt thanks for rebasing the branch, I don't think that anything really critical was lost. |
The snapshot is currently incompatible with the top-of-tree swift-syntax. We could pin to 4ae758ab85ed2a5d3e3e8b5050a8ce52179bd102 or wait until a new snapshot is tagged. |
@compnerd If a new snapshot expected sometime today or tomorrow, I think we should wait for that. That said, you're welcome to temporarily tag against that commit to get CI passing, in which case I can hold off on merging. |
I don't think that there is a guaranteed window for the next tag. It is attempted nightly but anything that gets introduced can prevent the tagging. The last one occurred ~2 weeks ago (as an example). I think that tagging is likely the safer route to unblock ourselves. I can double check if we can (accidentally get away with 5.4) Edit: verified that 5.5 is required for the prebuilt |
Temporarily pin to 4ae758ab85ed2a5d3e3e8b5050a8ce52179bd102 which would allow building on Windows.
@compnerd Oh, I didn't realize that nightly tags were so flakey. In that case, yeah — let's pin to a commit. It looks like CI is passing, so I'll go ahead and merge this now. Thanks! |
Add coverage for Windows with Swift 5.5