Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache key is unstable with additional cargo installs #140

Closed
stevenh opened this issue May 13, 2023 · 0 comments · Fixed by #142
Closed

cache key is unstable with additional cargo installs #140

stevenh opened this issue May 13, 2023 · 0 comments · Fixed by #142

Comments

@stevenh
Copy link
Contributor

stevenh commented May 13, 2023 •
edited
Loading

If additional cargo installs happen after the cache step the calculation of cache key between restore and save is unstable due to it now including the registered package, as added by #138.

I'll work on a fix for this and put up a PR.
@Swatinem Swatinem mentioned this issue May 15, 2023
Closed
stevenh added a commit to stevenh/rust-cache that referenced this issue May 16, 2023
@stevenh
fix: cache key stability
5ae9fd1 
Ensure consistency of main and post configuration by storing and
restoring it from state.

Also:
* Fixed some typos.
* Use core.error for logging errors.

Reverts: Swatinem#138
Fixes Swatinem#140
stevenh added a commit to stevenh/rust-cache that referenced this issue May 16, 2023
@stevenh
fix: cache key stability
0403955 
Ensure consistency of main and post configuration by storing and
restoring it from state, which in turn ensures cache key stability.

Also:
* Fixed some typos.
* Use core.error for logging errors.

Reverts: Swatinem#138
Fixes Swatinem#140
@stevenh stevenh mentioned this issue May 16, 2023
Merged
stevenh added a commit to stevenh/rust-cache that referenced this issue May 16, 2023
@stevenh
fix: cache key stability
f7c18cd 
Ensure consistency of main and post configuration by storing and
restoring it from state, which in turn ensures cache key stability.

Also:
* Fixed some typos.
* Use core.error for logging errors.

Reverts: Swatinem#138
Fixes Swatinem#140
stevenh added a commit to stevenh/rust-cache that referenced this issue May 16, 2023
@stevenh
fix: cache key stability
0f040b6 
Ensure consistency of main and post configuration by storing and
restoring it from state, which in turn ensures cache key stability.

Also:
* Fixed some typos.
* Use core.error for logging errors.

Reverts: Swatinem#138
Fixes Swatinem#140
stevenh added a commit to stevenh/rust-cache that referenced this issue May 16, 2023
@stevenh
fix: cache key stability
5fa5161 
Ensure consistency of main and post configuration by storing and
restoring it from state, which in turn ensures cache key stability.

Also:
* Fixed some typos.
* Use core.error for logging errors.

Reverts: Swatinem#138
Fixes Swatinem#140
stevenh added a commit to stevenh/rust-cache that referenced this issue May 16, 2023
@stevenh
fix: cache key stability
9b4b3d7 
Ensure consistency of main and post configuration by storing and
restoring it from state, which in turn ensures cache key stability.

Also:
* Fixed some typos.
* Use core.error for logging errors.

Reverts: Swatinem#138
Fixes Swatinem#140
stevenh added a commit to stevenh/rust-cache that referenced this issue May 17, 2023
@stevenh
fix: cache key stability
1d5cfc6 
Ensure consistency of main and post configuration by storing and
restoring it from state, which in turn ensures cache key stability.

Also:
* Fixed some typos.
* Use core.error for logging errors.

Reverts: Swatinem#138
Fixes Swatinem#140
stevenh added a commit to stevenh/rust-cache that referenced this issue May 17, 2023
@stevenh
fix: cache key stability
d5a9bd4 
Ensure consistency of main and post configuration by storing and
restoring it from state, which in turn ensures cache key stability.

Also:
* Fixed some typos.
* Use core.error for logging errors.
* Fix inverted condition on cache-all-crates.

Reverts: Swatinem#138
Fixes Swatinem#140
stevenh added a commit to stevenh/rust-cache that referenced this issue May 17, 2023
@stevenh
fix: cache key stability
68377a4 
Ensure consistency of main and post configuration by storing and
restoring it from state, which in turn ensures cache key stability.

Also:
* Fixed some typos.
* Use core.error for logging errors.
* Fix inverted condition on cache-all-crates.

Reverts: Swatinem#138
Fixes Swatinem#140
Swatinem pushed a commit that referenced this issue May 18, 2023
@stevenh
fix: cache key stability (#142)
ad97570 
Ensure consistency of main and post configuration by storing and
restoring it from state, which in turn ensures cache key stability.

Also:
* Fixed some typos.
* Use core.error for logging errors.
* Fix inverted condition on cache-all-crates.

Reverts: #138
Fixes #140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: cache key stability stevenh/rust-cache
1 participant
@stevenh