remove price impact filter from ExactIn trades #1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for swapr ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Diogomartf
force-pushed
the
try-removing-unsortedTrades
branch
from
53021c9 to
82f29a6
Compare
Diogomartf
changed the title
|
If this code is hurting us, I think we should remove. Probably better to show all the answers, that way users know that there is an option from X, Y or Z AMM. |
berteotti
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove price impact filters from trades, this is blocking some tokens who have diff price impact rules, we should probably do a more robust solution if we want to filter on price impact.