[SWA-128][FEAT] - Update social links, links to Range Liquidity and new Popup #1889

ElRodrigote · 2023-12-20T16:51:31Z

Fixes: SWA-128

Description

Update Discords links
Remove $SWPR ClaimModal component
Add new Range Liquidity header link
Add new Range Liquidity popup component

Visual evidence

How to test the changes

Pull this branch
Run the project locally
Go to Swapr landing page
Connect your wallet
The new popup and header item should be visible, and they should redirect the user to https://swapr.liquidity.eth.limo/, all Discord links should send a correct invitation to Swapr Discord and the Claim modal to claim $SWPR should be unavailable

netlify · 2023-12-20T16:51:36Z

✅ Deploy Preview for swapr ready!

Name	Link
🔨 Latest commit	`1f7af31`
🔍 Latest deploy log	https://app.netlify.com/sites/swapr/deploys/658dd43b27323900087b8cb6
😎 Deploy Preview	https://deploy-preview-1889--swapr.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 25 (no change from production) Accessibility: 80 (🟢 up 3 from production) Best Practices: 92 (no change from production) SEO: 67 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

public/locales/de/common.json

src/constants/urls.ts

Diogomartf · 2023-12-21T16:13:29Z

Let's change the banner text to to be consistent:

"Provide concentrated liquidity in Gnosis Chain"

I think the most clear term is concentrated liquidity.

Diogomartf · 2023-12-21T16:14:33Z

Also the font is super big, I would decrease it a bit.

berteotti

Code looks good, made a few comments to improve little things and some design related stuff.

src/components/Header/index.tsx

berteotti · 2023-12-21T17:02:20Z

src/components/Header/index.tsx

-      <ClaimModal
-        onDismiss={toggleClaimPopup}
-        newSwprBalance={newSwprBalance}
-        stakedAmount={stakedTokenAmount?.toFixed(3)}
-        singleSidedCampaignLink={
-          data && !loading ? `/rewards/single-sided-campaign/${data.stakeToken.address}/${data.address}` : undefined
-        }
-      />


Why are we removing this?

This was a request from @0xVenky as far as I understood in the ticket:
https://linear.app/swaprhq/issue/SWA-128/update-social-links-and-showcase-new-amm-concentrated-liq

src/components/Popups/LiquidityV3Popup.tsx

src/constants/urls.ts

src/state/application/hooks.tsx

berteotti · 2023-12-22T10:21:42Z

Can we have a smaller font on mobile?

berteotti

Good Job Rorry, just a small typo on the banner. It can be merged after that fix.

berteotti · 2023-12-28T10:35:58Z

src/constants/urls.ts

+export const DISCORD_INVITE_LINK = process.env.DISCORD_INVITE_URL ?? 'https://discord.com/invite/QFkNsjTkzD'
+export const LIQUIDITY_V3_LINK = process.env.LIQUIDITY_V3_URL ?? 'https://swapr.liquidity.eth.limo/#/info/pools'


src/pages/Pools/LiquidityV3Banner/index.tsx

…ge Liq popup

…ty to Liquidity V3

…y V3 in the app header

…onent

…ls page

…nner from div into anchor

… URLs constants

…, included mobile styles

…up and Banner (#1889) * chore(SWA-128): update Discord links * prune(STK-128): remove SWPR ClaimModal component * feat(SWA-128): add new Liquidity V3 header link * feat(SWA-128): create Liquidity V3 popup and update Tostify styles * feat(SWA-128): create the Liquidity V3 banner and place it on our Pools page

ElRodrigote requested review from Diogomartf and berteotti December 20, 2023 16:51

github-actions bot temporarily deployed to feat-swa-128-update-social-links-and-showcase-new-amm-concentra December 20, 2023 16:57 Destroyed

Diogomartf reviewed Dec 20, 2023

View reviewed changes

public/locales/de/common.json Outdated Show resolved Hide resolved

ElRodrigote requested a review from Diogomartf December 20, 2023 19:45

github-actions bot temporarily deployed to feat-swa-128-update-social-links-and-showcase-new-amm-concentra December 20, 2023 19:50 Destroyed

ElRodrigote marked this pull request as draft December 21, 2023 15:19

Diogomartf reviewed Dec 21, 2023

View reviewed changes

src/constants/urls.ts Outdated Show resolved Hide resolved

berteotti reviewed Dec 21, 2023

View reviewed changes

github-actions bot temporarily deployed to feat-swa-128-update-social-links-and-showcase-new-amm-concentra December 21, 2023 20:33 Destroyed

ElRodrigote requested review from berteotti and Diogomartf December 21, 2023 21:02

ElRodrigote marked this pull request as ready for review December 21, 2023 21:03

github-actions bot temporarily deployed to feat-swa-128-update-social-links-and-showcase-new-amm-concentra December 21, 2023 21:08 Destroyed

Diogomartf approved these changes Dec 27, 2023

View reviewed changes

berteotti approved these changes Dec 28, 2023

View reviewed changes

ElRodrigote added 10 commits December 28, 2023 11:07

chore(SWA-128): update Discord links

6f3833d

prune(STK-128): remove SWPR ClaimModal component

71c20a9

feat(SWA-128): add new Range Liquidity header link

f95bfc0

chore(SWA-128): add and update needed SVGs for Range Liquidity popup

388aa8e

feat(SWA-128): create Range Liquidity popup and update Tostify styles

e1c47a5

feat(SWA-128): add new header item and replace Stackly popup with Ran…

1a641b7

…ge Liq popup

refactor(SWA-128): PR comment to rename everything from Range Liquidi…

12d7bcb

…ty to Liquidity V3

chore(SWA-128): PR comment to move the NEW badge from DCA to Liquidit…

11b42ae

…y V3 in the app header

chore(SWA-128): PR comment to update Liquidity V3 URL

c6670f9

refactor(SWA-128): abstract Liquidity V3 token pair logos into a comp…

30af407

…onent

ElRodrigote added 7 commits December 28, 2023 11:14

chore(SWA-128): add the img for our liquidity v3 banner

2bcd063

chore(SWA-128): PR comment to update the Liquidity V3 Popup font size

95fed6f

feat(SWA-128): create the Liquidity V3 banner and place it on our Poo…

6058128

…ls page

refactor(SWA-128): PR comment to update the Liquidity V3 Popup and Ba…

b2deb21

…nner from div into anchor

prune(SWA-128): remove unneeded link badge for Liquidity V3 header item

ae576d6

chore(SWA-128): PR comment to consume env vars with fallbacks for our…

f3e59bd

… URLs constants

refactor(SWA-128): PR comment to remove unneeded useCallback hook

1301bfd

ElRodrigote force-pushed the feat/swa-128-update-social-links-and-showcase-new-amm-concentrated-liq branch from 67a6081 to 1301bfd Compare December 28, 2023 14:31

github-actions bot temporarily deployed to feat-swa-128-update-social-links-and-showcase-new-amm-concentra December 28, 2023 14:37 Destroyed

styles(SWA-128): update Liquidity V3 toast and banner copy and styles…

1f7af31

…, included mobile styles

github-actions bot deployed to feat-swa-128-update-social-links-and-showcase-new-amm-concentra December 28, 2023 20:07 View deployment

ElRodrigote merged commit a46fe88 into develop Dec 29, 2023
18 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SWA-128][FEAT] - Update social links, links to Range Liquidity and new Popup #1889

[SWA-128][FEAT] - Update social links, links to Range Liquidity and new Popup #1889

ElRodrigote commented Dec 20, 2023

netlify bot commented Dec 20, 2023 •

edited

Loading

Diogomartf commented Dec 21, 2023

Diogomartf commented Dec 21, 2023

berteotti left a comment

berteotti Dec 21, 2023

ElRodrigote Dec 21, 2023

berteotti commented Dec 22, 2023

berteotti left a comment

berteotti Dec 28, 2023

		export const DISCORD_INVITE_LINK = process.env.DISCORD_INVITE_URL ?? 'https://discord.com/invite/QFkNsjTkzD'
		export const LIQUIDITY_V3_LINK = process.env.LIQUIDITY_V3_URL ?? 'https://swapr.liquidity.eth.limo/#/info/pools'

[SWA-128][FEAT] - Update social links, links to Range Liquidity and new Popup #1889

[SWA-128][FEAT] - Update social links, links to Range Liquidity and new Popup #1889

Conversation

ElRodrigote commented Dec 20, 2023

Fixes: SWA-128

Description

Visual evidence

How to test the changes

netlify bot commented Dec 20, 2023 • edited Loading

✅ Deploy Preview for swapr ready!

Diogomartf commented Dec 21, 2023

Diogomartf commented Dec 21, 2023

berteotti left a comment

Choose a reason for hiding this comment

berteotti Dec 21, 2023

Choose a reason for hiding this comment

ElRodrigote Dec 21, 2023

Choose a reason for hiding this comment

berteotti commented Dec 22, 2023

berteotti left a comment

Choose a reason for hiding this comment

berteotti Dec 28, 2023

Choose a reason for hiding this comment

netlify bot commented Dec 20, 2023 •

edited

Loading