Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Cases in Product where Text Does Not Exist #62

Merged
merged 1 commit into from
Dec 15, 2017

Conversation

justinyost
Copy link
Contributor

There are cases where returning a Product Entity, the text field does not exist. This catches that issue.

Resolves Issue #61

There are cases where returning a Product Entity, the text field does not exist. This catches that issue.

Signed-off-by: Justin Yost <[email protected]>
@justinyost
Copy link
Contributor Author

Error in Travis Build is related to a change that has occurred in evaluating urls with the filter_var, note here https://3v4l.org/NERQ1 up to PHP 5.6.27 this would have been false, but now evaluates as true starting in PHP 5.6.28 and forward. Possibly related this bug fix in PHP https://bugs.php.net/bug.php?id=73192 Here are the notes for PHP 5.6.28 https://secure.php.net/ChangeLog-5.php#5.6.28

@Swader Swader merged commit 5d49e6c into Swader:master Dec 15, 2017
@Swader
Copy link
Owner

Swader commented Dec 15, 2017

Thank you! Will change travis setup.

@justinyost
Copy link
Contributor Author

Thanks @Swader points to you.

@justinyost justinyost deleted the issue-61-product-text-field branch December 15, 2017 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants