Fix issue - 2144. Replace socketio.py #93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the comments from @cyberw, I have fixed the issue - locustio/locust#2144. Please find the below code for the file - locust-plugins/locust_plugins/users/socketio.py. Please review and commit the code accordingly.
|
Hi! Looks like you have added a completely new file instead of modifying the old one? And added some comments in python file itself? And called the parameter **options instead of the standard **kwargs? And not used the double-splat when forwarding it on line 28? That cant even work, can it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the comments from @cyberw, I have fixed the issue - locustio/locust#2144. Please find the below code for the file - locust-plugins/locust_plugins/users/socketio.py. Please review and commit the code accordingly.
Hi @cyberw,
I have modified the socketio.py file. Please review and merge this pull request. Thanks.
Regards,
Balaji.