Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements #98

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Minor improvements #98

merged 2 commits into from
Aug 6, 2024

Conversation

acosmicflamingo
Copy link
Contributor

Added some minor improvements:

  • Make YouTubePlayer.state property publicly accessible if YouTubePlayerKit is imported using @_spi attribute
  • Fix background thread crash issues by isolating YouTubePlayerKit views and models to main actor
  • Send playerStatePublisher updated state in case .onChange
    • Once the player state becomes .error, the next time you cue a new video, case .onReady won't ever be accessed but instead it'l go to case .onStateChange, so anything subscribed to playerStateSubject publisher will not ever be told that it's ready again.

@acosmicflamingo acosmicflamingo mentioned this pull request Jul 20, 2024
Closed
@SvenTiigi SvenTiigi changed the base branch from main to develop August 3, 2024 07:01
@SvenTiigi
Copy link
Owner

LGTM 👍

@SvenTiigi SvenTiigi merged commit 805fe79 into SvenTiigi:develop Aug 6, 2024
3 checks passed
@artistbuddy artistbuddy mentioned this pull request Aug 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SvenTiigi SvenTiigi SvenTiigi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acosmicflamingo @SvenTiigi