Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] The default reader settings should be changable #214

Closed
schroda opened this issue Jan 1, 2023 · 0 comments · Fixed by #217
Closed

[Feature Request] The default reader settings should be changable #214

schroda opened this issue Jan 1, 2023 · 0 comments · Fixed by #217
Labels
enhancement New feature or request

Comments

@schroda
Copy link
Collaborator

schroda commented Jan 1, 2023

What feature should be added to Tachidesk?

The default reader settings used for mangas that haven't been read yet should be changeable in the settings.

Why/Project's Benefit/Existing Problem

In case you use the same reader settings most of the time and are only changing them for some mangas, it is annoying to always have to change the "default" used reader settings
@schroda schroda added the enhancement New feature or request label Jan 1, 2023
This was referenced Jan 1, 2023
Merged
Merged
AriaMoradi pushed a commit that referenced this issue Jan 6, 2023
@schroda
make default reader settings changeable (#217)
dca968f 
* [#214] Move "reader settings" util functions into new file

* [#214] Extract "options" of "ReaderSettings" to new component

* [#214] Add component for changing the default reader settings

* [#214] Add default "ReaderSettings" to "Settings"

* [#214] Use default "ReaderSettings" stored on the server

Wait for both "manga" and "defaultSettings" to be loaded.
Otherwise, by the time the "manga" response was received, the "defaultSettings" might be still loading and thus, the local fallback "default" settings will get used as the "default settings"

* [#214] Save and update "ReaderSettings" options in case they are missing

- Manga gets read the first time => save settings in metadata
- Default settings get opened the first time => save settings in global metadata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make default reader settings changeable
1 participant
@schroda