-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break out Metadata to separate library #1182
Conversation
@AndersAbel should we use the |
What assembly is it in? |
There is one in |
As far as I know the one in |
I see. Upon checking again, still not available in .NET Core |
@AndersAbel need to rerun the action, I'm getting all of the test as passed on my local |
Ignore it, the report says "internal error". I hope the next commit will work. |
@AndersAbel I've moved codes of the metadata except the loader and scheduler |
@rpmansion Sounds great. I'll have a look and get it merged. |
@AndersAbel reviewing the code base, what is the reason why we do not maximize the use of |
Do you have an example? I can think of two reasons: 1. It was not available on .NET Core when the port was done. 2. It doesn't contain all the properties to properly represent the metadata. |
Good first step to breaking metadata out to a separate library. Thanks! |
Linking #1181 issue. @AndersAbel Thank you for merging, will further add new changes. :) |
Move metadata codes from Sustainsys.Saml2 to Sustainsys.Saml2.Metadata project except for codes related to loader and scheduler.