Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break out Metadata to separate library #1182

Merged
merged 4 commits into from
Apr 15, 2020

Conversation

rpmansion
Copy link
Contributor

@rpmansion rpmansion commented Apr 10, 2020

Move metadata codes from Sustainsys.Saml2 to Sustainsys.Saml2.Metadata project except for codes related to loader and scheduler.

@rpmansion
Copy link
Contributor Author

@AndersAbel should we use the EntityId from IdentityModel? If yes, will remove the one in the code base.

@AndersAbel
Copy link
Member

@AndersAbel should we use the EntityId from IdentityModel? If yes, will remove the one in the code base.

What assembly is it in?

@rpmansion
Copy link
Contributor Author

rpmansion commented Apr 11, 2020

What assembly is it in?

There is one in System.IdentityModel and one in Sustainsys.Saml2.Metadata

@AndersAbel
Copy link
Member

What assembly is it in?

There is one in System.IdentityModel and one in Sustainsys.Saml2.Metadata

As far as I know the one in System.IdentityModel is not available in .NET Core. That's the reason we created an own one.

@rpmansion
Copy link
Contributor Author

As far as I know the one in System.IdentityModel is not available in .NET Core. That's the reason we created an own one.

I see. Upon checking again, still not available in .NET Core

@rpmansion
Copy link
Contributor Author

@AndersAbel need to rerun the action, I'm getting all of the test as passed on my local

@AndersAbel
Copy link
Member

Ignore it, the report says "internal error". I hope the next commit will work.

@rpmansion
Copy link
Contributor Author

@AndersAbel I've moved codes of the metadata except the loader and scheduler

@rpmansion rpmansion changed the title Metadata: move some related codes from Sustainsys.Saml2 Move Metadata codes to Sustainsys.Saml2.Metadata project Apr 11, 2020
@rpmansion rpmansion changed the title Move Metadata codes to Sustainsys.Saml2.Metadata project Break out Metadata to separate library Apr 11, 2020
@AndersAbel
Copy link
Member

@rpmansion Sounds great. I'll have a look and get it merged.

@rpmansion
Copy link
Contributor Author

@AndersAbel reviewing the code base, what is the reason why we do not maximize the use of System.Security.Cryptography.Xml instead of creating our own classes that are already exist in such library?

@AndersAbel
Copy link
Member

@AndersAbel reviewing the code base, what is the reason why we do not maximize the use of System.Security.Cryptography.Xml instead of creating our own classes that are already exist in such library?

Do you have an example? I can think of two reasons: 1. It was not available on .NET Core when the port was done. 2. It doesn't contain all the properties to properly represent the metadata.

@AndersAbel AndersAbel merged commit d18499c into Sustainsys:master Apr 15, 2020
@AndersAbel
Copy link
Member

Good first step to breaking metadata out to a separate library. Thanks!

@rpmansion
Copy link
Contributor Author

rpmansion commented Apr 16, 2020

Linking #1181 issue. @AndersAbel Thank you for merging, will further add new changes. :)

@AndersAbel AndersAbel added this to the v3.0.0 Flexibility milestone Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants