feat: add isShort property to videoCompact. #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuspiciousLookingOwl
requested changes
Nov 13, 2024
|
Thanks for the PR, got a small comment |
xiaohaoxing
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
feat: add isShort property to videoCompact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greeting, friend!
As "Shorts" becomes a popular video type on youtube, it seems that it's useful to figure out if a video is a shorts video or not.
I've found that
isLiveproperty reads a fieldthumbnailOverlayTimeStatusRenderer.style. And developer of youtube also use this field to tag a 'SHORTS' on the cover of video. So I think it's reliable to use this field to judge if a video isShorts.Thanks to your review.