Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction on flow of events #4

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Correction on flow of events #4

merged 1 commit into from
Jan 26, 2022

Conversation

koush
Copy link
Contributor

@koush koush commented Aug 19, 2021

The data stream is not opened until a motion service reports activity. I'm unsure if this lazy connect behavior I am observing was a change from the original behavior when the spec was written, but that is how it works now.

The data stream is not opened until a motion service reports activity. I'm unsure if this lazy load was a change from the original behavior when the spec was written, but that is how it works now.
@Supereg
Copy link
Owner

Supereg commented Aug 19, 2021

This sounds a bit weird to me that apple would wait until the first(?) motion event. After all stuff can go wrong.
If its okay I would try to test that out myself.

@koush
Copy link
Contributor Author

koush commented Aug 19, 2021

This sounds a bit weird to me that apple would wait until the first(?) motion event. After all stuff can go wrong.
If its okay I would try to test that out myself.

Go for it. This is just what I've found through my current testing. I was wondering if I was doing something wrong because I wasn't receiving the incoming data stream connection. Tested everything, and then on a hunch tried triggering motion, and that's when the connection comes in. Have seen this behavior reliably in my current implementation.

Here's my fork, hoping to be done sometime tomorrow:

https://github.com/koush/HAP-NodeJS/blob/master/src/lib/camera/RecordingManagement.ts

@Supereg Supereg merged commit f1d9bf7 into Supereg:master Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants