Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to the pane's tab style #361

Merged

Conversation

javier-tarazaga
Copy link
Contributor

Description of the Change

Added the following changes:

  • Make the entire tab space a little bit smaller to gain a few more pixels of real state for the editor.
  • Added a selected tab underline to clearly see which is the selected tab.
  • Minor color and padding fixes for the x button in the tabs.

filippsen
filippsen previously approved these changes Jan 29, 2019
Copy link
Contributor

@filippsen filippsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • "Make the entire tab space a little bit smaller ...": thinner tab and style changes, OK
  • "Added a selected tab underline...:": was this the one removed on the very last commit (7eb3df7) ? If so, OK.
  • "Minor color and padding fixes for the x button...": subtle effect on mouse over and style changes, OK.

@javier-tarazaga javier-tarazaga merged commit 49f7c58 into SuperblocksHQ:master Jan 29, 2019
@filippsen filippsen mentioned this pull request Mar 25, 2019
@javier-tarazaga javier-tarazaga deleted the improve-panes-style branch April 23, 2019 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants