Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug with pane resizing after moving between tabs and switching side panels #355

Merged
merged 2 commits into from
Jan 17, 2019

Conversation

ostap1010
Copy link
Contributor

Description

  • Open README.MD
  • Open dapp.json
  • Open side panel
  • Navigate to README.MD

Actual result: editor window is empty
Expected result: README.MD content is displayed

Copy link
Contributor

@filippsen filippsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Reproduce original bug in 1.6.0 (lab-beta).
    Unclear what the "open side panel" exactly means: open Preview or Transactions history ? Or resize the left side menu ?
    Regardless of that, it seems that any modification to the layout (from any side or panels) causes that. I do see the file contents not redrawing when switching over different open files (no editor or any contents). OK
  • Running this request (commit 56b5eb5), experimented with other resize and layout variants, combined with multiple other files. Unable replicate the bug. Editor and contents are always displayed. OK

@ostap1010 ostap1010 merged commit a01eac7 into SuperblocksHQ:master Jan 17, 2019
@filippsen filippsen mentioned this pull request Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants