Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use yarn only instead of make file #330

Merged
merged 15 commits into from
Jan 7, 2019
Merged

Use yarn only instead of make file #330

merged 15 commits into from
Jan 7, 2019

Conversation

ostap1010
Copy link
Contributor

Description of the Change

There are small problem when running makefile commands on Windows. In order to fix this - migrate make file functionality to yarn commands

Fixes issue

#292

javier-tarazaga
javier-tarazaga suggested changes Jan 7, 2019
View reviewed changes
Copy link
Contributor

@javier-tarazaga javier-tarazaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, now when running yarn start, the page does not load at first (it is simply empty) and I need to hit refresh in order to actually load the app.

bashlund
bashlund reviewed Jan 7, 2019
View reviewed changes
.env.beta Outdated Show resolved Hide resolved
@ostap1010 ostap1010 merged commit 3af0042 into SuperblocksHQ:master Jan 7, 2019
@ostap1010 ostap1010 deleted the make-yarn branch January 7, 2019 15:03
@filippsen filippsen mentioned this pull request Jan 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashlund bashlund bashlund left review comments

@javier-tarazaga javier-tarazaga javier-tarazaga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ostap1010 @bashlund @javier-tarazaga