Change ORIGIN variable in the make file #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filippsen
approved these changes
Jan 4, 2019
There was a problem hiding this comment.
- Simplifies
make distcommands for release. Always good. OK - Works locally (browsing to lab-beta.[...]:3000 and lab.[...]:3000) without setting
ORIGIN_DISTfor bothmake dist_betaandmake distcommands. OK - Interact window works (lab and lab-beta behave the same). OK
- App view window works (lab and lab-beta behave the same). OK
- Development mode is unaffected. OK
This was referenced Jan 4, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.