Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor UI updates #290

Merged
merged 1 commit into from
Dec 17, 2018
Merged

Minor UI updates #290

merged 1 commit into from
Dec 17, 2018

Conversation

javier-tarazaga
Copy link
Contributor

Description of the Change

Added minor UI updates:

  1. Reduce the topbar and right panel height/width to allow a little bit more real state for coding
  2. Used the modalHeader comp in the newDapp flow.
  3. Change the close icon from FA to ionic custom svg

Benefits

More real state for what really matters (coding) and consolidated header behavior for all modals.

@javier-tarazaga javier-tarazaga added the feature-request New feature or request label Dec 15, 2018
@javier-tarazaga javier-tarazaga requested review from Spejbl and removed request for donfrigo December 15, 2018 10:08
Spejbl
Spejbl approved these changes Dec 17, 2018
View reviewed changes
Copy link
Contributor

@Spejbl Spejbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended.

@javier-tarazaga javier-tarazaga merged commit b8c5657 into SuperblocksHQ:master Dec 17, 2018
@javier-tarazaga javier-tarazaga deleted the minor-ui-update branch December 17, 2018 14:01
@filippsen filippsen mentioned this pull request Dec 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spejbl Spejbl Spejbl approved these changes

Assignees
No one assigned
Labels
feature-request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@javier-tarazaga @Spejbl