Add constraint for when moving a dir into it's own sub dir. Fixes iss… #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filippsen
approved these changes
Dec 11, 2018
There was a problem hiding this comment.
- Unable to reproduce Unable to move folder with files inside #273 after the changes. OK
- Action will continue to throw an error without consequences. Files will not be deleted when trying to move a directory into its own directory. OK
- A couple of minor typos which I fixed with commit 20a1cda. OK
OK!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fixes #273, about moving a directory into it's own subdirectory accidentally deletes all files of the directory.
Alternate Designs
In the future we will not have the option of moving files "by hand" by specifying the new path, we will instead have drag and drop for moving files/dirs.
Benefits
Files will not be deleted when trying to move a directory into it's own directory.
Verification Process
See issue #273
Github Issues
#273